New release?

New release?, a forum discussion on Jojo CMS. Join us for more discussions on New release? on our General Announcements forum.

Back to Forum Index : Back to General Announcements Page << [1] [2] [3] [4] [5] >>  RSS
tom

Developer

tom

27 Feb 2013
Posts: 379

The current master seems pretty stable to me - I haven't seen any showstopping new bugs and it has a lot to offer over 1.15. Ready for 1.2?

Once we have a new tag out I'd like to move the default settings to something more progressive - html5, less-enabled, a minimal version of modernizr (essentially just the shiv and a js test), jquery 1.7 and add in jquery 1.9 as an option.

..and Bootstrap is up to 2.3 now also which adds in a few nice extras (indicators on the carousel) as well as a lot of bug fixes but I can't for the life of me work out how to reset the commit pointer on a submodule..
Harvey

Core Developer

Harvey

27 Feb 2013
Posts: 327

Submodules in Git are an abomination against god. It's like they were specifically designed to do exactly what you don't want them to do.

And they worked so seamlessly in SVN.
Rick Rick

27 Feb 2013
Posts: 336

Agreed with both Tom and Harvey. Also, Git doesn't let you checkout only a subfolder which bites sometimes. Plus there's the line endings crap and then filemodes too. All work-aroundable, but not seamless by default.

For submodules, browse into that submodule, update it like a normal repo, browse back to the parent repo and commit.
tom

Developer

tom

28 Feb 2013
Posts: 379

Ta - I got there eventually - the issue was confused by Bootstrap 2.3 being incompatible with LessPHP unless you update that too. Have done both and committed them to a new 'Edge' branch (along with jQ 1.9) if you want to play.. seems all good so far.

The submodule thing is very odd but I'm getting there with it. I do like git's branch / merge / tag stuff a lot more than svn.

I've pushed up a bunch of 5.4 fixes to master also and it seems currently pretty error free. Anyone have anything they want to get in before the next tag or can we go for it?
Jaijaz Jaijaz

5 Mar 2013
Posts: 215

Hey agree with pretty uncheck everything above. Except with submodules. Read this article recently on git submodules, it points out all the problems you've mentioned. However in the comments is a great response to how they should be used. I think it would be worth switching to that approach.
If you not living on the edge you taking up too much space.
tom

Developer

tom

8 Mar 2013
Posts: 379

1.2 is out and available for download or from git.
Submodules don't get included in git zip files so if you're wanting an archive copy, the download is the better option.

Also, I've updated this site to the current version of Jojo and done a quick hack of the template to turn it into a Bootstrap responsive site because... I could.
tom

Developer

tom

9 Jul 2013
Posts: 379

And another? Ready for 1.2.3
Mostly for Contact form bug fixes. Anyone got anything in the wings they want holding off for to get in? (Not that it's that desperate now we're tagging more frequently)
Rick Rick

9 Jul 2013
Posts: 336

After the tag I might push the password upgrade I put into the Edge branch over to Master (unless you'd like to), but because of it being such a core feature I'd like a second set of eyes on it before pushing it over to the Master branch if anyone is keen. If everyone is too busy then I'll wait a while to forget what I did then look over it again myself.

It should be issue-free and not actually upgrade passwords until setup has been run (otherwise it'd all break), but there are bound to be scenarios I haven't thought of or tested.
tom

Developer

tom

14 Jul 2013
Posts: 379

I've tagged 1.2.3.

On master now I've pushed Rick's password update across and also stripped out almost all of Jojo's form styling and updated the classing of form elements so they can be left to Bootstrap to make nice or styled in the theme without doing loads of overrides. The sites I've tried on so far have mostly adapted well (particularly if they were using Bootstrap already).

Over on the Edge branch I'm trying out converting the whole Jojo admin area to use Bootstrap. And it's looking pretty nice I reckon. Still quite a bit of finessing to do yet but I'm out of time for the moment.
I don't think it breaks anything although I haven't tried it out on a site with cart plugins yet. One side effect is that now Less is always enabled (I haven't removed the option yet but it doesn't do anything), but then I'm thinking that's probably a good thing.

t1Peter t1Peter

14 Jul 2013
Posts: 8

Tom, you have been busy!

I just download and upload to testing server 1.2.3 to have a look see...
However I'm getting a setup script error, which I'm sure I've seen somebody else mention recently.
:(

Checking indexes for option...
PRIMARY - op_name
Index on `op_category`missing
.Executing Query: ALTER TABLE option ADD INDEX (`op_category`);
ALTER TABLE option ADD INDEX (`op_category`); You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'option ADD INDEX (`op_category`)' at line 1

I'm sure I've got all the folder permissions set properly.
Has anyone thought of updating the setup script to do these automatically?
tom

Developer

tom

15 Jul 2013
Posts: 379

It's a SQL index problem, and shouldn't be anything related to permissions.
That is the setup script running both the check and the fix automatically - it's failing on adding the index to the database table for some reason. Maybe the table doesn't exist yet? I take it this is a fresh install - does it go away if you run setup again or does it always hang at that point? Can you run the query directly and if so do you get the same error message back?


t1Peter t1Peter

15 Jul 2013
Posts: 8

Yep - Fresh install.

This still happens when I run setup again, the 'op_category' does exist.

Comparing the table to previous install on another DB it looks the same.

MySQL 5.1.37
Php 5.2.17
t1Peter t1Peter

15 Jul 2013
Posts: 8

Ok - got past this by starting again.
install previous 1.0 version - all OK

change config to point to new version (deleting the cache as well)
rerun setup - Viola! -
except no bootstrap formating - though I suspect that is what the submodule error was.
Rick Rick

15 Jul 2013
Posts: 336

Thanks for pushing over (and fixing!) the new password code.

You're powering ahead with a lot of progress on Jojo, I wish I had the time to help.
tom

Developer

tom

16 Jul 2013
Posts: 379

My current idea is to make the edge branch the 1.3 base, so bug fixes and so on can be made to master and further 1.2.x tags can be done off that if needed. Then merge those changes up onto edge as needed so that it can be used for a new 1.3.0 tag, in line with how other projects seem to do it.

The additional stuff is not earth shattering but it does probably require some intervention when upgrading to it (checking forms and adjusting styling as needed to replace what's been ripped out) so I figure that makes it a 1.x level change.

The admin has had quite an overhaul, but it's pretty much all cosmetic so I can't see there being any particular issues with that. Feedback on the aesthetics / responsive handling / column widths etc would be welcome though.
tom

Developer

tom

28 Jul 2013
Posts: 379

I'd like to start tagging plugins also, or at least branching them for 1.3 - mainly for bootstrapping/lessifying stuff like the cart plugins (because 1.3 will have less permanently enabled)
tom

Developer

tom

19 Aug 2013
Posts: 379

1.3.1: In the absence of any objections..
my current plan is (probably later this week or next) to tag 1.2.5 from master now that the various install/setup issues appear to be (finally) resolved.
Then merge the edge branch down into master and tag it for 1.3.1.
And use the edge branch to start playing with Bootstrap 3, which although it will break backward compatibility, has a lot of nice features and is considerably more streamlined and flexible than 2.
tom

Developer

tom

17 Jan 2014
Posts: 379

1.4 is pretty much ready to go now so I'm thinking to do a 1.4.0 release off the Edge branch.

1.3 seems pretty stable but there are bound to be a few more bug fixes that will need a 1.3.3 release so I'll leave master on that track for now until that's done and then look to merge Edge down into Master at that point.

One potential sticking point is that the lessphp developer has more or less abandoned that project and as it stands it only work for Bootstrap 3.0.0. I haven't actually seen any issues myself from not having 3.0.3 but it would make sense to keep it up to date if possible. Hopefully others will step in to take lessphp over and update it but it may end up being necessary to move to another project.

If we do get a workable version of 1.4 out, I'll tag the cart plugins for 1.3 and start converting their edge branches across to BS3 compatible versions. There are probably other plugins that make heavy use of forms that could also do with pushing in that direction.
Rick Rick

17 Jan 2014
Posts: 336

The LessPHP stuff is unfortunate. Having Less compiled within Jojo is a huge time saver for me and it'd be a huge step backward to have to use a build process outside of Jojo to compile things. I don't mind swapping LessPHP out for another lib if we can find one though. I'd look at attacking it but from a glance, parts of the code are above my skill level. I've looked at SASS a bit (a bit clearer syntax, but much the same) but couldn't find a good PHP compiler for that either.

I thought about moving Bootstrap out to a plugin to make it more updatable, but then that makes maintaining the plugins that use it even harder. Probably best to just keep pushing along updating Bootstrap, the core and plugins as we go (I say we, but it's been all you).

I've done some UI tweaks to admin area but it's still a little odd at the edges with responsiveness. Completely redesigned the menu though but it goes weird with an invisible special char dumped out at the to of top of /admin/plugins/. Screenshot attached. I'd still love to do a complete redesign of the backend layout but I'm too busy job hunting :(

The small thing I'd like to add before a new release is a permissions check on the mysite directory as part of installation. I've been caught a couple of times because it fails badly since it can't write, so it starts the error logger which loads via some generic code that goes through plugins (which cascades along for a while). I'll do this if I have time but the next thing I'll be working on is the Fieldception plugin I mentioned as it will really change the way I do a lot of things in Jojo. I might be a bit arrogant about it and release it as a "hambrook_" plugin on my own account so that I can claim the kudos for development job applications. I'll still submodule it to the JojoCMS-Plugins account though.
Jaijaz Jaijaz

2 Feb 2014
Posts: 215

Hey guys. Yes I'm still alive.

One library to look at the CSS and js asset management is Assetic https://github.com/kriswallsmith/assetic

I looked at a heap in my last job but could find the time of implementing it. Has SASS support to so people could swap out to foundation if they prefer over bootstrap.

One day I'll find time to work on Jojo again. Missing it and the people a lot.

Hope your all well.
If you not living on the edge you taking up too much space.
Back to Forum Index : Back to General Announcements Page << [1] [2] [3] [4] [5] >>  RSS
You must be logged in to post a reply



You need to Register or Log In before posting on these forums.